Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API does not throw error when Availability Zone of a nodepool is updated #669

Open
2 tasks done
valaparthvi opened this issue Sep 23, 2024 · 0 comments
Open
2 tasks done

API does not throw error when Availability Zone of a nodepool is updated #669

valaparthvi opened this issue Sep 23, 2024 · 0 comments
Assignees
@mjura @valaparthvi
Labels
kind/bug Something isn't working
Milestone
v2.9.3

Comments

@valaparthvi
Copy link
Contributor

valaparthvi commented Sep 23, 2024 •
edited by mjura
Loading

Ideally, it is not possible to update the Availability Zone of a cluster nodepool once it has been created, Rancher Dashboard does not allow it, but updating this via API does not raise any error. It simply reverts the changes to AKSConfig after a few minutes.

The API should raise an error when the user tries to update NodePool Availability Zone.

Steps to reproduce:

  1. Create a cluster and note the AZ of nodepools.
  2. Update the cluster nodepool AZ via API.
  3. Check AKSConfig, the AZ must have been updated.
  4. Check Azure Cloud Console, the AZ must stay intact.
  5. Wait for a few minutes until AKSConfig is restored to its original state.

Expected results:
The API must throw an error saying that updating the Availability Zone is not allowed.

Rancher version: v2.9-5fcd75d6ef3870052ec4b3e8ab0b77fb680473ac-head
AKS Operator version: rancher/aks-operator:v1.9.2

PR's:
@cpinjani cpinjani added the kind/bug Something isn't working label Sep 25, 2024
@mjura mjura self-assigned this Sep 27, 2024
mjura added a commit to mjura/aks-operator that referenced this issue Oct 1, 2024
@mjura
Add validation for modifications to availability zones
cb67801 
Updating Availability Zone is not allowed for Azure AKS.

Issue: rancher#669
mjura added a commit to mjura/aks-operator that referenced this issue Oct 1, 2024
@mjura
Add validation for modifications to availability zones
e9d77c1 
Updating Availability Zone is not allowed for Azure AKS.

Issue: rancher#669
(cherry picked from commit cb67801)
@mjura mjura mentioned this issue Oct 1, 2024
Merged
5 tasks
mjura added a commit to mjura/aks-operator that referenced this issue Oct 1, 2024
@mjura
Add validation for modifications to availability zones
8f4a309 
Updating Availability Zone is not allowed for Azure AKS.

Issue: rancher#669
(cherry picked from commit cb67801)
@mjura mjura mentioned this issue Oct 1, 2024
Merged
5 tasks
@kkaempf kkaempf added this to the v2.9.3 milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjura mjura

@valaparthvi valaparthvi

Labels
kind/bug Something isn't working
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Status: To Test
Milestone
v2.9.3
Development

No branches or pull requests
4 participants
@kkaempf @mjura @valaparthvi @cpinjani