Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze Layout update #8

Open
wants to merge 55 commits into
base: FRv20Updates
Choose a base branch
from

Conversation

yungshinlintw
Copy link

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

hapandar and others added 16 commits October 16, 2019 23:55
… Sets (Azure#7484)

* Update swagger to support AutomaticRepairs for VMScaleSet

* Fix unreferenced file error

* Small change - Modify the description for grace period
* adding azure cli readme files

* updated readme.cli

* proper regexes

* fix
* adding a baseline folder for PolicyInsights 2019-10-01

* fixing validation errors.

* fix go build error

* Added spec json files for other resources to be added to the package. Also updated policyStates.json as per latest API changes.

* Added new columns in the examples. Also, Removed metadata path.
…#7437)

* Swagger changes for Dynamics S2S auth.

* Fix mistakes.
* Adding FR v2.0 API updates

* PR Validation: Fix typo, missing file ref.

* PR Validation: Fix missed typo

* PR Validation: fixing model verification errors, doc string fixes.

* Fixing model verification, added Receipts endpoints, related examples.

* Fixing semantic validation error

* Update labelFile param

* fixing types

* Fixing model validation errors

* Fixing model verification errors, other fixes.

* Fixing mode verification error.

* Fixing typo.

* Fixing doc strings, Location header update, Change response code for Analyze calls

* Incorporating feedback from Paul.

* Feedback from Florian, verification fix.

* Fixing for merge verification.

* fixing for model verification tests

* fixing model verification errors.

* fixing example file to correct useLabelFile option.
"/layout/analyzeResults/{resultId}": {
"get": {
"summary": "Get Analyze Layout Result",
"operationId": "GetAnalyzeLayoutResult",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"description": "Track the progress and obtain the result of the analyze layout operation.",

"200": {
"description": "Success",
"schema": {
"$ref": "#/definitions/AnalyzeLayoutOperationResult"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent is for forms/receipts/layout to all use AnalyzeOperationResult instead of different output formats.

@@ -872,6 +958,72 @@
}
}
},
"AnalyzeLayoutOperationResult": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need AnalyzeLayoutOperationResult and AnalyzeLayoutResult.

"responses": {
"200": {
"body":{
"status": "running",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running would not have result. Change to succeeded.

"x-ms-parameter-location": "method",
"type": "string",
"x-ms-enum": {
"name": "OcrDetectionLanguage",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse Language for the x-ms-enum name so we don't generate a new enum type in the SDK. I have verified this in SDK generation.

prpandey3004 and others added 11 commits October 18, 2019 02:48
… 2019-06-01 (Azure#7440)

* [Storage] Add 2019-06-01 api version

* [Storage] Private Endpoint Connection swagger

* Added missing put privateendpoint connection definition

* PUT privateendpointconnection definition
* some refactoring/renaming
* SDK build failure due to same enum name

* Marking PrivateLinkServiceConnectionState.status as enum

* Added default error response for new apis
…ern Commerce Account Scopes to Query and Dimension APIs. (Azure#7491)

* Adds base for updating Microsoft.CostManagement from version stable/2019-09-01 to version 2019-10-01

* Updates readme

* Updates API version in new specs and examples

* Updated Query and Dimension API to support GTM Scopes plus examples. Fixed an existing issue in Query API by removing value

* Fixed a small issue

* Fixed typo

* Removing unused example

* removed extra line

* Added new item for Go Package

* removed nextlink

* Fixed some minor issues

* Fixed some minor issues and also added missing description for properties

* addressed some minor issues

* added legacy vs modern

* fixed a small issue
…ew Credits, lots, Event APIs, and Modern scopes for Usage Details ,and Charges APIs. (Azure#7459)

* Adds base for updating Microsoft.Consumption from version stable/2019-06-01 to version 2019-10-01

* Updates readme

* Updates API version in new specs and examples

* Introducing new API Version 2019-10-01 with adding Credits, Lots, Events, Charges APIs and related examples

* Removed extra bracket

* Added missing bracket

* Added missing definitions

* Added missing CreditbalanceSummary

* Fixed issues for startDate and endDate

* Fixed a small issue in consumption.json

* removed GTM scopes from usage Detail

* fixed typo

* Removed charges for GTM Scope and all related examples

* Changed amount as object which includes amount plus currency

* addressed some minor issues

* Removed extra properties from credit summary

* update credit summary definition

* removed properties from creditbalancesummary

* Fixed an issue

* resolved couple of format issues

* updated description bases on ARM Suggestion

* Added support for GTM UsageDetail by introducing Kind

* fixed a small issue

* Adding Modern Scopes for Charges API with the kind support

* removed extra examples

* Updating Usage Detail for Modern

* Fixed some typos

* Updated charges examples

* Added reservation recommendation, summary, details for Modern scopes plus supporting kind for recommendation

* did some minor changes

* made some minor changes
* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (Azure#7173)

* temp fix

* Adding new VirtualMachines.POST.Reapply action to compute api-version: 2019-07-01. Updating parameter info for skus api-version:2019-04-01..  (Azure#7167)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* Adding new VirtualMachines.POST.Reapply action.

* Adding example for POST Reapply virtual machine action.

* Adding missing $filter parameter documentation to skus.json for api-version: 2019-04-01.

* Unexpected change.

* Added DiskEnryptionSet property in the managed disk parameters for the VM/VMSS (Azure#7293)

*  updated swagger

*  updated swagger

* Removed example files which are not relevant and added links to examples for newly added property

* fixed the syntax error

*  updated swagger

*  fixed the sytax error

* Added examples for the DiskEncryptionSet property (Azure#7318)

*  updated swagger

*  updated swagger

* Removed example files which are not relevant and added links to examples for newly added property

* fixed the syntax error

*  updated swagger

*  fixed the sytax error

*  updated code

*  udpated swagger to create DiskEncryptionSet as new property to initiate

* Resolved conflicts with DiskRP definition names for the DiskEncryptionSet (Azure#7340)

*  updated swagger

*  updated swagger

* Removed example files which are not relevant and added links to examples for newly added property

* fixed the syntax error

*  updated swagger

*  fixed the sytax error

*  updated code

*  udpated swagger to create DiskEncryptionSet as new property to initiate

* resolved conflicts and updated swagger due to conflict in the DiskRP definitions

* Disk 2019-07-01 version (Azure#7280)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (Azure#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples (Azure#7429)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (Azure#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples

* Add extension API for VMScaleset VMs (Azure#7407)

* add extension Api

* change operationID

* update description

* update description

* add examples

* add missing /

* add missing / in examples

* add new line

* remove unnecessary file

* add reference examples

* fix model validation failures

* remove provisioning state from params

* remove unnecessary param

* fix Delete example

* updating the description of storage account id (Azure#7385)

* Private temp (Azure#7456)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (Azure#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples

* Remove uniqueId in swagger

* Remove required for diskEncryptionSetId

* cherry pick code owner change to compute-2019-07 (Azure#7480)

* Iops, throughput and instance view (Azure#7499)

* Swagger changes for IOPS, Bulk InstanceView, documentation for GETVM and InstanceView

* Fixed typos

* Updated samples

* Update 2019-07 from latest 2019-03 update.

* Update swagger (Azure#7510)

* Copy compute.json and runCommands.json from 2019-03-01 to 2019-07-01

* changes to add publicIpAddressVersion field (Azure#7173)

* Add diskEncryptionSet in swagger compute-2019-07

* resolve semantic conflicts

* Fix model conflicts

* Resolve readme

* Resolve readme

* Resolve description conflicts

* Improve description

* Fix spell error

* Add some examples.

* fix model error

* Update examples

* Remove uniqueId in swagger

* Remove required for diskEncryptionSetId

* Update principalId and tenantId to be readonly

* small space fix

* add update property (Azure#7514)

* Sync with the latest 2019-03-01 version to 2019-07-01 version of compute.

* suppress LintDiff validation error.

* Add default responses to new APIs.
… per code implementation (Azure#7524)

* Billing RP spec changes for listInvoiceSectionsWithCreateSubscriptionPermission API

* Updated the operation id

* Added x-ms-pageable

* Added next link

* Deleted unused file ProductCancelByBillingAccount

* Incorporated review comments

Incorporated review comments

* Added new properties in Invoicing APIs

Added new properties in Invoicing APIs

* Incorporated review comments

Incorporated review comments

* Added invoiceEmailOptIn in the UpdateBillingProfile request

Added invoiceEmailOptIn in the UpdateBillingProfile request

* Update billing.json

* Updating the verbs from Create BillingProfile and InvoiceSection entities

Updating the verbs from Create BillingProfile and InvoiceSection entities
sornaks and others added 26 commits October 21, 2019 09:34
* Update autorest config and swagger to support new API version 2019-11-01.

* Re-write description of some of the responses in Cache_Create.json and storagecache.json.

* Description updates.

Ready for re-review.

* Remove references to PATCH storagetarget

* Update C/ST_Create to C/ST_CreateOrUpdate

* Fix formatting.

* Fix tag name to align with previous version tags and GO SDK namespace.
* add aks rotate-certs operation for 2019-08-01

* feat: use 204 instead of 200
…on (Azure#7552)

* [Storage] Sync swagger changes from 2019-04-01 to 2019-04-01 apiversion

* Removing skiptoken which is not being used by the service

* The skiptoken is not used by the service, removing it from latest swagger.
* Adding feature assigning APIs

* Remove Pattern Feature APIs

* fix build
* Refactory CognitiveServicesAccount model specification.

* fix samples
* Updating the docs to include rankerType field in QueryDTO

* PR comments
…/stable/2019-05-06 (Azure#7511)

* Apply branding changes to stable/2019-05-06 and track1/stable/2019-05-06

* Address code review comments
* Hybrid RP swagger

* Addressed feedback

* fix typo

* fix build issues

* fix validation issues

* fix validation errors

* fix errors

* fix errors

* fix errors

* remove 204 return codes

* updated examplese
…Azure#7486)

* Approved deployments scripts swagger from private repo

* Update readme files and fix typo

* Update property letter casing

* Removing the containerSettings property due to network profile not supporting user assigned MSI.

* Update specification/resources/resource-manager/readme.csharp.md

update package name

Co-Authored-By: Yeming Liu <[email protected]>
* Adds base for updating Microsoft.ContainerService from version stable/2019-08-01 to version 2019-10-01

* Updates readme

* Updates API version in new specs and examples

* added private FQDN (Azure#7430)

* added private FQDN

* added example

* remove example

* updating sdk tags for 2019-10-01 api version (Azure#7550)

* updating sdk tags for 2019-10-01 api version

* fixing ci errors
…into layoutUpdate

# Conflicts:
#	specification/cognitiveservices/data-plane/FormRecognizer/preview/v2.0/FormRecognizer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.