Render user custom html for widget. #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndharrison
changed the title
jjallaire
reviewed
Oct 31, 2016
| @@ -226,7 +226,9 @@ widget_html <- function(name, package, id, style, class, inline = FALSE, ...){ | |||
|
|
|||
| # call the custom function if we have one, otherwise create a div | |||
| if (is.function(fn)) { | |||
| fn(id = id, style = style, class = class, ...) | |||
| renderTags( | |||
There was a problem hiding this comment.
I don't know if this is the right fix. It might rather be to surround the results of the function in an html-preserve comment (which will also prevent pandoc from touching it). @jcheng5 What's the best thing here?
|
Hi @jjallaire sure this was just a temporary fix used on a widget I had. I thought it maybe helpful to provide the pull request. Looking at ?htmltools::htmlPreserve that looks like the tool for the job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #239 issue with custom html via "_html" not being rendered.