Skip to content

Commit

Permalink
Merge pull request #464 from ramnathv/rc-v1.6.2
Browse files Browse the repository at this point in the history
v1.6.2 release candidate
  • Loading branch information
cpsievert committed Mar 17, 2023
2 parents 7587396 + 71d9b03 commit cf04bf0
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 195 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: htmlwidgets
Type: Package
Title: HTML Widgets for R
Version: 1.6.1.9000
Version: 1.6.2
Authors@R: c(
person("Ramnath", "Vaidyanathan", role = c("aut", "cph")),
person("Yihui", "Xie", role = c("aut")),
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
htmlwidgets 1.6.1.9000
htmlwidgets 1.6.2
------------------------------------------------------

* Closed #452: `as.tag.htmlwidget()` now includes `...` in it's function signature (for compatibility with the `htmltools::as.tags` generic).
Expand Down
11 changes: 1 addition & 10 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Revdeps

## Failed to check (22)
## Failed to check (21)

|package |version |error |warning |note |
|:-------|:-------|:-----|:-------|:----|
Expand All @@ -25,13 +25,4 @@
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |
|NA |? | | | |

## New problems (3)

|package |version |error |warning |note |
|:--------------|:-------|:------|:-------|:----|
|[clinUtils](problems.md#clinutils)|0.1.3 |__+1__ | |1 |
|[connectwidgets](problems.md#connectwidgets)|0.1.1 |__+1__ | |1 |
|[slickR](problems.md#slickr)|0.5.0 |__+1__ | | |

18 changes: 2 additions & 16 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,21 +1,7 @@
## revdepcheck results

We checked 289 reverse dependencies (267 from CRAN + 22 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.
We checked 296 reverse dependencies (275 from CRAN + 21 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

* We saw 3 new problems
* We saw 0 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* clinUtils
checking tests ... ERROR

* connectwidgets
checking tests ... ERROR

* slickR
checking tests ... ERROR

35 changes: 0 additions & 35 deletions revdep/failures.md
Original file line number Diff line number Diff line change
Expand Up @@ -732,39 +732,4 @@ Run `revdepcheck::cloud_details(, "NA")` for more info
```
# NA

<details>

* Version: NA
* GitHub: NA
* Source code: https://github.com/cran/NA
* Number of recursive dependencies: 0

Run `revdepcheck::cloud_details(, "NA")` for more info

</details>

## Error before installation

### Devel

```
```
### CRAN

```
```
133 changes: 1 addition & 132 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -1,132 +1 @@
# clinUtils

<details>

* Version: 0.1.3
* GitHub: https://github.com/openanalytics/clinUtils
* Source code: https://github.com/cran/clinUtils
* Date/Publication: 2022-10-24 16:25:08 UTC
* Number of recursive dependencies: 104

Run `revdepcheck::cloud_details(, "clinUtils")` for more info

</details>

## Newly broken

* checking tests ... ERROR
```
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
> test_check("clinUtils")
[ FAIL 2 | WARN 0 | SKIP 2 | PASS 300 ]
══ Skipped tests ═══════════════════════════════════════════════════════════════
• On CRAN (2)
══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test_knitPrintListPlots.R:151'): A list of interactive plots (plotly) is correctly included ──
grep("class=\"plotly html-widget\"", outputHTMLPlots) has length 0, not length 2.
── Failure ('test_knitPrintListPlots.R:169'): A list of interactive objects (plotly) is correctly included ──
grep("class=\"plotly html-widget\"", outputHTMLObjects) has length 0, not length 2.
[ FAIL 2 | WARN 0 | SKIP 2 | PASS 300 ]
Error: Test failures
Execution halted
```

## In both

* checking installed package size ... NOTE
```
installed size is 6.5Mb
sub-directories of 1Mb or more:
doc 5.4Mb
```

# connectwidgets

<details>

* Version: 0.1.1
* GitHub: https://github.com/rstudio/connectwidgets
* Source code: https://github.com/cran/connectwidgets
* Date/Publication: 2021-07-23 09:40:02 UTC
* Number of recursive dependencies: 79

Run `revdepcheck::cloud_details(, "connectwidgets")` for more info

</details>

## Newly broken

* checking tests ... ERROR
```
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
output[[1]][[4]]$attribs$class not equal to "rsc_grid html-widget html-widget-output".
1/1 mismatches
x[1]: "rsc_grid html-widget html-widget-output shiny-report-size html-fill-item-
x[1]: overflow-hidden"
y[1]: "rsc_grid html-widget html-widget-output"
── Failure ('test-rsc_search.R:89'): rscsearchOutput ───────────────────────────
output[[1]][[4]]$attribs$class not equal to "rsc_search html-widget html-widget-output".
1/1 mismatches
x[1]: "rsc_search html-widget html-widget-output shiny-report-size html-fill-ite
x[1]: m-overflow-hidden"
y[1]: "rsc_search html-widget html-widget-output"
[ FAIL 4 | WARN 4 | SKIP 0 | PASS 114 ]
Error: Test failures
Execution halted
```

## In both

* checking dependencies in R code ... NOTE
```
Namespaces in Imports field not imported from:
‘R6’ ‘httr’ ‘jsonlite’
All declared Imports should be used.
```

# slickR

<details>

* Version: 0.5.0
* GitHub: https://github.com/yonicd/slickR
* Source code: https://github.com/cran/slickR
* Date/Publication: 2020-12-18 16:10:02 UTC
* Number of recursive dependencies: 91

Run `revdepcheck::cloud_details(, "slickR")` for more info

</details>

## Newly broken

* checking tests ... ERROR
```
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
── Failure ('test-widget.R:80'): slickR settings: add dots ─────────────────────
w1 + settings(dots = TRUE) not equal to readRDS("../assets/widget_settings.Rds").
Component "sizingPolicy": Names: 3 string mismatches
Component "sizingPolicy": Length mismatch: comparison on first 6 components
Component "sizingPolicy": Component 4: target is NULL, current is list
Component "sizingPolicy": Component 5: Names: 1 string mismatch
Component "sizingPolicy": Component 5: Length mismatch: comparison on first 5 components
Component "sizingPolicy": Component 5: Component "fill": 1 element mismatch
Component "sizingPolicy": Component 6: Names: 1 string mismatch
Component "sizingPolicy": Component 6: Length mismatch: comparison on first 3 components
Component "sizingPolicy": Component 6: Component 3: target is NULL, current is logical
[ FAIL 8 | WARN 0 | SKIP 0 | PASS 19 ]
Error: Test failures
Execution halted
```

*Wow, no problems at all. :)*

0 comments on commit cf04bf0

Please sign in to comment.