Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authConfig form overlay: autocomplete="one-time-code" #350

Open
keul opened this issue Jul 20, 2023 · 4 comments
Open

authConfig form overlay: autocomplete="one-time-code" #350

keul opened this issue Jul 20, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@keul
Copy link
Contributor

keul commented Jul 20, 2023

Depending on the kind of authorization provided in the authConfig, the browser native password manager (or browser's plugin ones) can be very noisy in case the value of the password field is intended to be a short lived.

In this case a autocomplete="one-time-code" should enhance the user experience: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete

As this is probably not a solution for all usecases, it should be probably enabled on demand, like another option in the authConfig section.

@m-mohr
Copy link
Collaborator

m-mohr commented Jul 20, 2023

I wasn't aware of all these options for autocomplete, sounds great.
Happy to accept such a PR.

@m-mohr m-mohr added the enhancement New feature or request label Jul 20, 2023
@keul
Copy link
Contributor Author

keul commented Jul 20, 2023

@m-mohr happy to work on this in next days.

Question about the implementation: do you want a "free" new autocomplete property in authConfig (so, if I put "foo" there it will use "foo" in the markup) or something more controlled?

@m-mohr
Copy link
Collaborator

m-mohr commented Jul 20, 2023

To be compliant with #304, I think the authConfig should get something like:

generatorOptions: {
  autocomplete: "one-time-code"
}

Should one-time-code be the default? Would be fine with me, I think. And it can just be passed through, I think.

@keul
Copy link
Contributor Author

keul commented Jul 20, 2023

yup, for me "one-time-code" is a good default

@m-mohr m-mohr added this to the 3.2.0 milestone Sep 5, 2023
@m-mohr m-mohr modified the milestones: 3.2.0, 3.3.0 Mar 7, 2024
@m-mohr m-mohr modified the milestones: 3.3.0, 3.4.0 Aug 9, 2024
@m-mohr m-mohr modified the milestones: 3.4.0, 3.5.0 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants