Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be clearer when cancelling #2030

Open
hadley opened this issue Jul 30, 2024 · 2 comments
Open

Should be clearer when cancelling #2030

hadley opened this issue Jul 30, 2024 · 2 comments

Comments

@hadley
Copy link
Member

hadley commented Jul 30, 2024

> use_git()
✔ Setting active project to "/Users/hadleywickham/Desktop/knitr-error".
✔ Initialising Git repo.
✔ Adding ".Rhistory", ".Rdata", ".httr-oauth", ".DS_Store", and ".quarto" to
  .gitignore.
ℹ There are 4 uncommitted files:
• .gitignore
• knitr-error.Rproj
• manifest.json
• test.qmd
! Is it ok to commit them?

1: Not now
2: Yeah
3: Absolutely not

Selection: 1

It took me a while to notice that this had failed because I accidentally typed 1 instead of 2.

@jennybc
Copy link
Member

jennybc commented Jul 30, 2024

This would require some thought because the underlying helpers (ui_yep() and ui_nah()) are used lots of places (probably 20-30) and I don't think we would always want to do more than we're doing now. Nor would we always want to say the same thing in response to a particular choice.

@hadley
Copy link
Member Author

hadley commented Jul 30, 2024

I think we could reliably say "Terminating execution" or similar though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants