Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansi_strwrap() needs a better implementation, that does not rely on base::strwrap() #325

Open
Tracked by #317
gaborcsardi opened this issue Aug 4, 2021 · 2 comments
Labels
feature a feature request or enhancement

Comments

@gaborcsardi
Copy link
Member

No description provided.

@gaborcsardi gaborcsardi changed the title ansi_strwrap() needs a better implementation, that does not rely on base::strwrap(). Might not happen in this PR. ansi_strwrap() needs a better implementation, that does not rely on base::strwrap() Aug 4, 2021
@gaborcsardi gaborcsardi added the feature a feature request or enhancement label Aug 4, 2021
@olivroy
Copy link
Contributor

olivroy commented Jul 21, 2023

If an hyperlink has spaces, should it be kept together?

for example

"here is {.href [I am a very longggggggggggggggggggg link to a website](https://github.com)

Should it be all kept on the same line?

@gaborcsardi
Copy link
Member Author

@olivroy I don't think so.

But that's not really what this issues is about. base::strwrap() is simply slow, and it is really tricky to rely on it while keeping the ANSI sequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants