Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Que recurringly freeze deserialized params when plugged into ActiveJob? #304

Open
guilherme-andrade opened this issue Jan 25, 2021 · 0 comments

Comments

@guilherme-andrade
Copy link

ActiveJob by default deserializes the params passed to jobs when running execute.

These params can either be literals or objects like ActiveRecord::Base model objects, that should be able to be modified within Que#run.

This however is not possible due to this line, which recurringly freezes all arguments passed by ActiveJob's QueAdapter, causing FrozenError all over the place.

Shouldn't it be removed or is it a requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant