Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix broken CI #977

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

arnaucasau
Copy link
Contributor

@arnaucasau arnaucasau commented Nov 7, 2023

Summary

This PR fixes the broken CI.

Summary of the changes:

  • Update the tox version -> tox==4.11.0
  • Update the virtualenv version to match the new tox version -> virtualenv==20.19.0
  • Fix unit test test_qlibrary_3_options.py (line 291, line 490, and lines 499-502)
  • Fix the style of BridgeFreeJJ.py and test_qlibrary_3_options.py for the lint test

Details

The main problem with the CI was that tox wasn't able to set up the test environment. If we look at the errors, tox finds an error when calling the prepare_metadata_for_build_editable function. We had that problem because we were pinning tox to use an old version, and the pyproject-api version that we are using (pyproject-api==1.6.1) is not able to work with old versions of tox. The solution for this first problem was to change the CI to use a more recent version of tox. This update forces us to also use a more recent version of virtualenv because of the tox requirements.

Useful links to find more information about the problem:

  1. https://www.github.com/tox-dev/tox/issues/3110
  2. https://www.github.com/pypa/setuptools/issues/4031

Once we have the CI working again, we can discover another error, but this time with two tests in test_qlibrary_3_options.py. The two tests were also fixed and extended to validate two more attributes of the default options of transmon_cross in transmon_cross.py that weren't taken into account before.

The last change is regarding the lint test for the files BridgeFreeJJ.py and test_qlibrary_3_options.py.

@arnaucasau arnaucasau marked this pull request as ready for review November 8, 2023 15:31
@arnaucasau
Copy link
Contributor Author

Hello @zlatko-minev! The CI is now working, but I have a question about test_qlibrary_3_options.py. To make the CI work, I changed two tests (line 291, line 490, and lines 499-502) because they were expecting fewer default options of transmon_concentric and transmon_cross than the ones they actually have. Was that intentional? In that case, I'll change them back! Thank you in advance!

Copy link
Collaborator

@zlatko-minev zlatko-minev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zlatko-minev zlatko-minev merged commit 74629bc into qiskit-community:main Nov 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants