Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the broken CI.
Summary of the changes:
test_qlibrary_3_options.py
(line 291, line 490, and lines 499-502)BridgeFreeJJ.py
andtest_qlibrary_3_options.py
for the lint testDetails
The main problem with the CI was that tox wasn't able to set up the test environment. If we look at the errors, tox finds an error when calling the
prepare_metadata_for_build_editable
function. We had that problem because we were pinning tox to use an old version, and the pyproject-api version that we are using (pyproject-api==1.6.1
) is not able to work with old versions of tox. The solution for this first problem was to change the CI to use a more recent version of tox. This update forces us to also use a more recent version of virtualenv because of the tox requirements.Useful links to find more information about the problem:
Once we have the CI working again, we can discover another error, but this time with two tests in
test_qlibrary_3_options.py
. The two tests were also fixed and extended to validate two more attributes of the default options oftransmon_cross
intransmon_cross.py
that weren't taken into account before.The last change is regarding the lint test for the files
BridgeFreeJJ.py
andtest_qlibrary_3_options.py
.