Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of jupyter-sphinx and sphinx-automodapi #960

Merged
merged 6 commits into from
Jul 6, 2023

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Jun 23, 2023

The docs render the same before and after this PR.

jupyter-sphinx is no longer being used in Terra because it caused build issues e.g. with parallelism and macOS. It wasn't used either in Metal, so it's good to remove.

This PR also removes the outdated build_docs script in favor of consistently using tox -e docs. We want one way to build the docs so things stay simple and consistent.

@Eric-Arellano Eric-Arellano changed the title WIP: debug tutorials not rendering Get rid of jupyter-sphinx Jun 27, 2023
@Eric-Arellano Eric-Arellano marked this pull request as ready for review June 27, 2023 15:14
@Eric-Arellano Eric-Arellano changed the title Get rid of jupyter-sphinx Get rid of jupyter-sphinx and sphinx-automodapi Jun 27, 2023
@zlatko-minev
Copy link
Collaborator

Still have this one stand out, should we close?

@Eric-Arellano
Copy link
Contributor Author

This results in no regression to tutorials:

Screenshot 2023-07-06 at 8 10 29 AM

@zlatko-minev zlatko-minev merged commit 7c16083 into qiskit-community:main Jul 6, 2023
8 checks passed
@Eric-Arellano Eric-Arellano deleted the debug-tutorials branch July 6, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants