Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more options for custom claws in TransmonCross #957

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

clarkmiyamoto
Copy link
Contributor

@clarkmiyamoto clarkmiyamoto commented Jun 22, 2023

What are the issues this pull addresses (issue numbers / links)?

Slight corrections & improvements to #949

Did you add tests to cover your changes (yes/no)?

Yes, updated corresponding tests for TransmonCross.

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

yes

Summary

The standard MIT LL candle qubit has a nonuniform claw thickness. One of the assumptions in the current TransmonCross is that you have uniform claw thickness, so this design isn't possible in Qiskit Metal (before this PR!). This update is to give front-end users more control of their claw designs.

Screen Shot 2023-06-21 at 11 17 54 PM

To illustrate what I mean here's a new potential design you can create.

And yes, it is backward compatible!

Details and comments

  • Increase customizability of TransmonCross claws.
  • Fixed pin placement of connector_type = 1

@zlatko-minev
Copy link
Collaborator

Ready for a review?

@clarkmiyamoto
Copy link
Contributor Author

Ready for a review?

Yeah ready!

Copy link
Collaborator

@zlatko-minev zlatko-minev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just double check this should be backward-compatible, right?

in other words, people who have made previous designs using this, won’t even notice a difference when loading the updated version. Unless you change one of these options, right

@clarkmiyamoto
Copy link
Contributor Author

in

Correct. If the user doesn't input ground_spacing_back or claw_width_back it'll default to a uniform style.

@zlatko-minev
Copy link
Collaborator

It's overall looking good to me, I'll plan to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants