Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies pinned too tightly #945

Open
wshanks opened this issue May 22, 2023 · 2 comments
Open

Dependencies pinned too tightly #945

wshanks opened this issue May 22, 2023 · 2 comments
Labels
good first issue Good for newcomers needs help open for contributions Issue submitted by the userbase

Comments

@wshanks
Copy link
Collaborator

wshanks commented May 22, 2023

#921 pinned all of the versions in requirements.txt to specific versions in order to avoid test failures. It makes sense to pin the dependency versions in tests to ensure consistency, but requirements.txt also gets used to pass to install_requires of setuptools to set the dependency versions of the package. Having all the dependencies pinned to specific versions (rather than looser ranges) makes it difficult to use qiskit-metal in an environment with other packages because all of those other packages have to be compatible with all of the pinned versions of qiskit-metal's dependencies.

If you want the tests to run against fixed dependency versions, one option is to add another requirements file named something like requirements-frozen.txt or requirements-pinned.txt, with all of the dependencies pinned while leaving looser ranges in requirements.txt. Then in tox.ini, you can put -r requirements-pinned.txt under the deps entry. Something to keep in with this approach is that if you allow newer versions of dependencies in requirements.txt but are not testing against them in CI you will not discover issues with new versions of the dependencies until a user complains.

@zlatko-minev
Copy link
Collaborator

Thank you, Will. We should do this.

I'm looking for help from folks here to try this?

@AbdullahKazi500
Copy link

Hi @zlatko-minev I am completely new to Metal and to open source may I try this issue I have a background in experimental physics and solid modelling of integrated circuits on ansys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers needs help open for contributions Issue submitted by the userbase
Projects
None yet
Development

No branches or pull requests

3 participants