Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing experiment configuration for restless experiments. #1338

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ItamarGoldman
Copy link
Contributor

@ItamarGoldman ItamarGoldman commented Dec 4, 2023

Summary

Force configuration of restless on an experiment as described in #795 .
Please describe what this PR changes as concisely as possible. Link to the issue(s) that this addresses, if any.

Details and comments

Some details that should be in this section include:

  • This change is necessary so restless experiment would run without errors due to run options that contradict restless experiment
  • An alternative solution was to make a restless experiment class. It was discarded because I wanted to change the code as less as possible.
  • What tests and documentation have been added/updated
  • If an experiment can be executed with restless configuration, Inheritance of RestlessMixin class should be first for correct method resolution order.

@ItamarGoldman ItamarGoldman changed the title [WIP] Forcing experiment configuration for restless experiments. Forcing experiment configuration for restless experiments. Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant