Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the compatibility of the number format #1951

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

wanghaochen2024
Copy link
Contributor

@wanghaochen2024 wanghaochen2024 commented Jul 15, 2024

PR Details

Represents language ID in decimal

Description

Add support for applying number format expression with language/location tags, to improve the compatibility of the number format for the Excelize.

Related Issue

N/A

Motivation and Context

Improve the compatibility of the number format

How Has This Been Tested

Complete documentation and unit tests, written unit test code in the numfmt_test.go source code, incremental test coverage of line should be 100%

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wanghaochen2024 wanghaochen2024 changed the title Improve the compatibility of the number format WIP: Improve the compatibility of the number format Jul 15, 2024
Copy link
Collaborator

@peng peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some comments. Please add unit test for this changes.

numfmt.go Show resolved Hide resolved
@wanghaochen2024
Copy link
Contributor Author

Hi @peng, I fixed the code review issue, please take a look. Thanks.

Copy link
Collaborator

@peng peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please also add unit test with [$-x-sysdate] number format code.

@wanghaochen2024 wanghaochen2024 changed the title WIP: Improve the compatibility of the number format Improve the compatibility of the number format Aug 26, 2024
@peng peng added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.31%. Comparing base (c805be1) to head (2607195).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1951   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          32       32           
  Lines       25230    25250   +20     
=======================================
+ Hits        25058    25078   +20     
  Misses         92       92           
  Partials       80       80           
Flag Coverage Δ
unittests 99.31% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@peng peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great work! Thanks for your contribution.

@peng peng merged commit 9c460ff into qax-os:master Aug 27, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Features
Development

Successfully merging this pull request may close these issues.

2 participants