Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new TickLabelPosition field in the ChartAxis data type #1946

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Add new TickLabelPosition field in the ChartAxis data type #1946

merged 1 commit into from
Jul 11, 2024

Conversation

imink
Copy link
Contributor

@imink imink commented Jul 11, 2024

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2024
@xuri xuri linked an issue Jul 11, 2024 that may be closed by this pull request
How to set the cross of XAxis and YAxis using AddChart function? #1944
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (53b6515) to head (d3f26b5).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1946   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          32       32           
  Lines       24980    24980           
=======================================
  Hits        24806    24806           
  Misses         93       93           
  Partials       81       81
Flag Coverage Δ
unittests 99.30% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xuri
xuri approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 431c310 into qax-os:master Jul 11, 2024
35 checks passed
zhangyimingdatiancai pushed a commit to zhangyimingdatiancai/excelize that referenced this pull request Aug 6, 2024
@imink @zhangyimingdatiancai
This closes qax-os#1944, add new TickLabelPosition field in the Chart…
33593a0 
…Axis data type (qax-os#1946)

- Introduce new exported ChartTickLabelPositionType enumeration
- Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuri xuri xuri approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Excelize v2.9.0
Status: Features
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to set the cross of XAxis and YAxis using AddChart function?
2 participants
@imink @xuri