Add new functions DeleteSlicer and GetSlicers #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuri
reviewed
Jul 10, 2024
…mory usage and 50% time cost (qax-os#1935) Co-authored-by: zhayt <[email protected]>
…nge (qax-os#1941) - Add unit test for get pivot table with across worksheet data range, update dependencies package and updated comments of the GetMergeCells function
… hyperlink by None linkType - Update unit tests
…Axis data type (qax-os#1946) - Introduce new exported ChartTickLabelPositionType enumeration - Update unit tests
… for zero numeric cell value (qax-os#1947) - Updated unit tests
…l is empty in pivot table data range - Update unit tests
qax-os#1953) Co-authored-by: Simmons <[email protected]>
…ith an IEEE 754 "not-a-number" value or infinity
…ed drawing object
…e without sysClr
- Fix missing conditional formatting after remove column - Fix the SetSheetVisible function panic on none views sheet - Updated unit tests
…ed drawing object
xuri
requested changes
Aug 7, 2024
zhangyimingdatiancai
changed the title
|
Hi @xuri, the |
xuri
reviewed
Aug 18, 2024
xuri
added
the
size/XL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1943 +/- ##
========================================
Coverage 99.31% 99.31%
========================================
Files 32 32
Lines 25002 25230 +228
========================================
+ Hits 24830 25058 +228
Misses 92 92
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xuri
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
GetSlicersfunction to get the slicer definition listDeleteSlicerfunction to delete specified slicer by the given slicer nameslicer.goandxmlSlicers.gosource codeDescription
Slicers in spreadsheets are filter tools used along with Excel tables or pivot tables over a large amount of data. Currently, the Excelize library already supports to creation of a slicer for the table or pivot table in the worksheet. The goal of this PR is to add the function for getting and deleting slicers and support for removing slicers by the given slicer name.
Related Issue
N/A
Motivation and Context
Add get and delete slicer support
How Has This Been Tested
Complete documentation and unit tests, written unit test code in the
slicer_test.gosource code, incremental test coverage of line reach 100%Types of changes
Checklist