Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue ##1682 - Delete table #1684

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

abdelaziz-ouhammou
Copy link
Contributor

PR Details

  • Removed the code that makes the table header cells empty after the table is deleted
  • Added a test to make sure that deleting a table does not make the header cells empty

Related Issue

#issue1682

How Has This Been Tested

Unit test added to table_test.go

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- DeleteTable does not delete table header values.
@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Merging #1684 (88396ae) into master (95fc35f) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
- Coverage   98.99%   98.99%   -0.01%     
==========================================
  Files          32       32              
  Lines       27446    27436      -10     
==========================================
- Hits        27170    27160      -10     
  Misses        183      183              
  Partials       93       93              
Flag Coverage Δ
unittests 98.99% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
table.go 99.30% <ø> (-0.02%) ⬇️

@xuri xuri merged commit 07f2c68 into qax-os:master Oct 6, 2023
39 checks passed
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

jenbonzhang pushed a commit to jenbonzhang/excelize that referenced this pull request Oct 22, 2023
@abdelaziz-ouhammou abdelaziz-ouhammou deleted the bugfix/fix-issue-1682 branch July 22, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants