Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref #65, add support for 10 formula functions #1630

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Conversation

fsfsx
Copy link
Contributor

@fsfsx fsfsx commented Aug 25, 2023

PR Details

Add support for 10 formula functions: ARRAYTOTEXT, FORECAST, FORECAST.LINEAR, FREQUENCY, INTERCEPT, ODDFYIELD, ODDLPRICE, ODDLYIELD, PROB and VALUETOTEXT

Motivation and Context

China Computer Federation (CCF) 2023 Code Camp

How Has This Been Tested

I have added unit test cases for this and all unit test passed.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

….LINEAR, FREQUENCY, INTERCEPT, ODDFYIELD, ODDLPRICE, ODDLYIELD, PROB, VALUETOTEXT
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #1630 (3005203) into master (15614ba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1630      +/-   ##
==========================================
+ Coverage   98.89%   98.91%   +0.01%     
==========================================
  Files          31       31              
  Lines       26140    26482     +342     
==========================================
+ Hits        25852    26194     +342     
  Misses        191      191              
  Partials       97       97              
Flag Coverage Δ
unittests 98.91% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
calc.go 99.15% <100.00%> (+0.02%) ⬆️

@xuri xuri added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 26, 2023
Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 4957ee9 into qax-os:master Aug 26, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants