Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The VM should have a name that describes its role #8

Open
iocanel opened this issue Nov 10, 2023 · 1 comment
Open

The VM should have a name that describes its role #8

iocanel opened this issue Nov 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@iocanel
Copy link
Collaborator

iocanel commented Nov 10, 2023

Currently we are using fedora as the name of the VM, which describes the OS rather than the role of the VM.
So, all related resources called fedora, should be renamed to podman-remote etc.

@cmoulliard
Copy link
Collaborator

Correct me if I'm wrong but the only resource that we are creating to install a KubeVirt VM is this one

apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  name: fedora38
  labels:
    app: fedora38
    vm.kubevirt.io/template: fedora-server-small
    vm.kubevirt.io/template.namespace: openshift
    vm.kubevirt.io/template.revision: '1'
    vm.kubevirt.io/template.version: v0.25.0

I suggest that we name the resource as you suggest but we also include as label the underlying OS or image used to figure out when issues will take place which OS/image we are using
-->

apiVersion: kubevirt.io/v1
kind: VirtualMachine
metadata:
  name: podman-remote
  labels:
    app: podman-remote
    vm-os: fedora38
    vm-image: quay.io/containerdisks/fedora:38
...

Warning: Be aware that if do that it will not be possible to create x VMS within the same namespace

@iocanel

@cmoulliard cmoulliard added the enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants