Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regularizer is not included in total loss #165

Open
hgjung97 opened this issue Sep 12, 2021 · 3 comments
Open

regularizer is not included in total loss #165

hgjung97 opened this issue Sep 12, 2021 · 3 comments

Comments

@hgjung97
Copy link

hgjung97 commented Sep 12, 2021

The current train loop calculates the total loss as below:
total_loss = giou_loss + conf_loss + prob_loss

This implementation doesn't include regularizer's loss, such as kernel_regularizer of Conv2D.
In my opinion, the above sentence should be modified as below to reflect regularizers.
total_loss = giou_loss + conf_loss + prob_loss + tf.add_n(yolo.losses)

Reference: tensorflow/tensorflow#21587

@pythonlessons
Copy link
Owner

Hmmm, this looks interesting, need to look at it

@hgjung97
Copy link
Author

hgjung97 commented Oct 8, 2021

When I applied such a modification, I got different results.

@pythonlessons
Copy link
Owner

When I applied such a modification, I got different results.

What were the results, were they better, have you compared the mAP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants