Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse order in example to avoid confusion #120

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

abravalheri
Copy link
Contributor

In #117 it was pointed out that the existing example may lead users to think comments that precede sections belong to those sections (which is not the case).

The idea behind this PR is to fix the example to avoid such interpretation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5254390806740992

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.656%

Totals Coverage Status
Change from base Build 5278751391481856: 0.0%
Covered Lines: 877
Relevant Lines: 893

💛 - Coveralls

@abravalheri abravalheri merged commit e80cb58 into main Aug 21, 2023
29 checks passed
@abravalheri abravalheri deleted the rewrite-confusing-example branch August 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants