Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"These apps are now globally available" is confusing now that --global is a thing #1460

Open
dechamps opened this issue Jun 25, 2024 · 4 comments Β· May be fixed by #1470
Open

"These apps are now globally available" is confusing now that --global is a thing #1460

dechamps opened this issue Jun 25, 2024 · 4 comments Β· May be fixed by #1470
Labels
docs good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dechamps
Copy link
Contributor

$ pipx --version
1.6.0
$ pipx install cowsay
  installed package cowsay 6.1, installed using Python 3.11.9
  These apps are now globally available
    - cowsay
done! ✨ 🌟 ✨

The phrasing "These apps are now globally available" seems to imply that I asked for a system-wide install using --global, but I didn't (and it didn't). This is confusing.

Alternatives include:

  • Just writing "These apps are now available"
  • Writing "These apps are now available user-wide" or "These apps are now available system-wide" depending on whether --global was passed
@huxuan huxuan added good first issue Good for newcomers help wanted Extra attention is needed docs labels Jun 26, 2024
@NerusSkyhigh
Copy link

Hi everyone,
I saw the tag "good first issue" and tried to help solve it.
I edited the file commands/common.py on line 352 with the first alternative suggested but while running the test I encountered some failures:

conda create --name pipx-test python pip
conda activate pipx-test
python -m pip install -e .
python -m pip install --user nox
nox -s tests-3.12

================================ short test summary info ================================
FAILED tests/test_environment.py::test_cli - AssertionError: assert False
FAILED tests/test_install.py::test_install_fetch_missing_python_invalid[3.1] - AssertionError: assert 0
= 2 failed, 344 passed, 8 skipped, 124 deselected, 1 xpassed, 7 warnings in 879.96s (0:14:39) =
nox > Command pytest --cov=pipx --cov-report= tests failed with exit code 1
nox > Session tests-3.12 failed.

As I don't think the line in itself is wrong (I mean, I only changed a string), I may need some help understanding the tests work so that I can contribute correctly. Any suggestion is welcome.

As we are on the topic, @dechamps, do you think it would be better to also change line 358 from These manual pages are now globally available to These manual pages are now available?

@huxuan
Copy link
Member

huxuan commented Jul 8, 2024

I saw the tag "good first issue" and tried to help solve it.

Thanks and welcome, @NerusSkyhigh!

I may need some help understanding the tests work so that I can contribute correctly. Any suggestion is welcome.

I would suggest to create a pull request in case there is some local environment releate error. If not, it is still more convenient to deal with the problem directly based on the pull request together.

As we are on the topic, @dechamps, do you think it would be better to also change line 358 from These manual pages are now globally available to These manual pages are now available?

IMO, it is fine. The globally term is kind of ambiguous. Let us wait for other buddies' response.

@NerusSkyhigh NerusSkyhigh linked a pull request Jul 8, 2024 that will close this issue
1 task
@NerusSkyhigh
Copy link

Hi, thanks for your time @huxuan .
I sent the pull request with the first change. Feel free to let me know if you need anything else.

For the second change, I'll wait for others' responses and change that if needed.

@Gitznik Gitznik linked a pull request Jul 8, 2024 that will close this issue
1 task
@Gitznik
Copy link
Contributor

Gitznik commented Jul 8, 2024

As we are on the topic, @dechamps, do you think it would be better to also change line 358 from These manual pages are now globally available to These manual pages are now available?

We might as well make it consistent while we're at it IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants