Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker to build lock file #59

Closed
matthewfeickert opened this issue Aug 18, 2023 · 0 comments · Fixed by #70
Closed

Use Docker to build lock file #59

matthewfeickert opened this issue Aug 18, 2023 · 0 comments · Fixed by #70
Assignees
Labels
enhancement New feature or request

Comments

@matthewfeickert
Copy link
Member

Given problems in PR #57 of building a pip-compile based lock file targeting Linux x86_64 when on a Apple silicon Mac, it is probably preferable to switch to building a lock file using a python:3.11 Docker container that can then force the environment to be x86_64, even if emulation is needed.

The workflow should also having @matthewfeickert's personal path information in the lock file, like it is now:

# pip-compile --generate-hashes --output-file=/home/feickert/Code/GitHub/pyhf-org/pyhf-tutorial/book/requirements.lock /home/feickert/Code/GitHub/pyhf-org/pyhf-tutorial/requirements.txt

as this injects noise in the diffs if anyone else builds it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant