Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent tocoo/to_coo methods on different sparse types #507

Open
mangecoeur opened this issue Aug 11, 2021 · 1 comment
Open

Inconsistent tocoo/to_coo methods on different sparse types #507

mangecoeur opened this issue Aug 11, 2021 · 1 comment
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@mangecoeur
Copy link
Contributor

There is some inconsistencies in the naming of to-coo methods: GCXS has tocoo, DOK has to_coo. I assume to some extent it's to have some compatibility with scipy sparse. But then why not just have both methods on all types?
@mangecoeur mangecoeur added the bug Indicates an unexpected problem or unintended behavior label Aug 11, 2021
@hameerabbasi
Copy link
Collaborator

We're considering deprecating those and using asformat always instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mangecoeur @hameerabbasi