Skip to content

Commit

Permalink
Require click>=8.1.4
Browse files Browse the repository at this point in the history
  • Loading branch information
ssbarnea committed Sep 11, 2023
1 parent 3531b7d commit 235635e
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 16 deletions.
9 changes: 2 additions & 7 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,10 @@ repos:
rev: v0.11.0
hooks:
- id: markdownlint
- repo: https://github.com/PyCQA/isort
rev: 5.10.1
hooks:
- id: isort
- repo: https://github.com/psf/black
rev: 21.12b0
rev: 23.9.1
hooks:
- id: black
language_version: python3
- repo: https://github.com/pre-commit/pre-commit-hooks.git
rev: v4.1.0
hooks:
Expand Down Expand Up @@ -41,7 +36,7 @@ repos:
types: [file, yaml]
entry: yamllint --strict
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.931
rev: v1.5.1
hooks:
- id: mypy
# empty args needed in order to match mypy cli behavior
Expand Down
4 changes: 1 addition & 3 deletions lib/gri/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ def run_query(self, query: Query, kind: str) -> int:
self.reviews.clear()
self.query_details = []
for server in self.servers:

try:
for review in server.query(query=query, kind=kind):
self.reviews.append(review)
Expand Down Expand Up @@ -291,7 +290,7 @@ def cli(ctx: click.Context, **kwargs):
ctx.obj = AppReviews(ctx=ctx)


@cli.resultcallback()
@cli.result_callback()
def process_result(result, **kwargs): # pylint: disable=unused-argument
output = kwargs["output"]
if kwargs["output"]:
Expand Down Expand Up @@ -417,5 +416,4 @@ def cli_bugs(ctx: click.Context, **kwargs):


if __name__ == "__main__":

cli() # pylint: disable=no-value-for-parameter
1 change: 0 additions & 1 deletion lib/gri/gerrit.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ def __init__(self, url: str, name: str = "", ctx=None) -> None:
)

def query(self, query: Query, kind="review") -> List:

# Gerrit knows only about reviews
if kind != "review":
return []
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ setup_requires =
# These are required in actual runtime:
install_requires =
click-help-colors>=0.6
click>=7.1.2
click>=8.1.4
dataclasses; python_version<"3.7"
enrich>=1.2.1
pygithub
Expand Down
7 changes: 3 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist = lint,packaging,py{36,37,38}
minversion = 3.7
envlist = lint,packaging,py{36,37,38,39,310}
minversion = 4.0
isolated_build = true
skip_missing_interpreters = true

Expand Down Expand Up @@ -28,14 +28,13 @@ commands =
-gri -o report.html owned incoming merged abandon draft watched

[testenv:lint]
basepython = python3.7
passenv = {[testenv]passenv}
# without PROGRAMDATA cloning using git for Windows will fail with an
# `error setting certificate verify locations` error
PROGRAMDATA
extras = lint
deps =
pre-commit >= 1.14.4, < 2
pre-commit >= 2
twine
readme-renderer[md] >= 24.0
pip >= 18.0.0
Expand Down

0 comments on commit 235635e

Please sign in to comment.