Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrumentation should report the service name through the application code #5864

Open
lubosmj opened this issue Oct 4, 2024 · 0 comments · May be fixed by #5865
Open

Instrumentation should report the service name through the application code #5864

lubosmj opened this issue Oct 4, 2024 · 0 comments · May be fixed by #5865
Labels
Issue Triage-Needed

Comments

@lubosmj
Copy link
Member

lubosmj commented Oct 4, 2024

We should report the name of the service (pulp-api, pulp-content, pulp-worker) from the pulpcore code itself.

Eventually, we will remove the OTEL_PREFIX from the service startup: https://github.com/pulp/pulp-oci-images/blob/f821ca7e0908027bc675e3988bb8a18170ac69ed/images/s6_assets/init/pulpcore-api#L6. Right now, we are running into issues with having both the auto-instrumentation (pulpcore code) and instrumentation agent (oci-image) reporting metrics with different attributes. We should strive to simplify the execution and instrumentation process.
lubosmj added a commit to lubosmj/pulpcore that referenced this issue Oct 4, 2024
@lubosmj
Emit the name of the Pulp service in all default metrics
a805453 
In addition to that, this commit fixes the attribute's name used for
reporting the name of the worker process.

closes pulp#5864
@lubosmj lubosmj linked a pull request Oct 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue Triage-Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit the name of the Pulp service in all default metrics lubosmj/pulpcore
1 participant
@lubosmj