Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm js - update bibly #9

Open
SimonRichardson opened this issue Jul 4, 2013 · 2 comments
Open

npm js - update bibly #9

SimonRichardson opened this issue Jul 4, 2013 · 2 comments
Assignees
@puffnfresh
Labels
enhancement question

Comments

@SimonRichardson
Copy link
Collaborator

Is it possible you can push the latest changes to bilby to https://npmjs.org/package/bilby
@ghost ghost assigned puffnfresh Jul 4, 2013
@SimonRichardson
Copy link
Collaborator Author

I've updated most of the issues you've found and it seems like you did a lot of the hard work for me 👍 - I went back to use Validation over Attempt and kept with Id over Identity. The only thing that was actually left on your list which you removed was the of method.

So it's completely up to you what you'd like to do, I'm also free to do anything else if you require, more unit tests, missing documentation.

The only thing that would be a nice pointer would be to have some examples/tests around the State structure.

@DamonOehlman
Copy link

👍 I'm keen to use 0.1 so yes please :)

@DamonOehlman DamonOehlman mentioned this issue May 6, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puffnfresh puffnfresh

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@puffnfresh @DamonOehlman @SimonRichardson