Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sftp.read to activity log #194

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

EpicPlayerA10
Copy link
Contributor

@EpicPlayerA10 EpicPlayerA10 commented Jul 1, 2024

Adds sftp.read to activity log when file is read in SFTP.

Resolves pterodactyl/panel#5136

Linked with PR pterodactyl/panel#5148

@danny6167
Copy link
Member

Thank you for your submission.

I've looked into this, and it appears there used to be logging for SFTP read events. It was dropped during the migration to sqlite based event buffer. If memory serves, I believe it was deliberately removed due to performance concerns.

I personally do like the idea of this being available. Access though the panel is logged so makes sense to be consistent, even if it has to be gated behind a config flag. So I'll see what @matthewpi want's to do about this.

@EpicPlayerA10
Copy link
Contributor Author

I don't think so that it would hit performance so much. I mean that sftp.read is very similar to sftp.write, except instead of trigerring on write, it triggers on read. sftp.write is already triggered very frequently without any performance issues, so all the more there will be no problems with sftp.read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sftp.read to activity log when someone opens a file via SFTP
2 participants