Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Panel API] Can't updated description #5178

Open
3 tasks done
Luiggi33 opened this issue Aug 2, 2024 · 3 comments · May be fixed by #5179
Open
3 tasks done

[Panel API] Can't updated description #5178

Luiggi33 opened this issue Aug 2, 2024 · 3 comments · May be fixed by #5179
Labels
bug Something that's not working as it's intended to be.

Comments

@Luiggi33
Copy link

Luiggi33 commented Aug 2, 2024

Current Behavior

When sending a PATCH request to the https://panel.[MY DOMAIN]/api/application/nodes/1 endpoint, the description in the body isn't updated. There response indicates, that everything was without an error, but the description remains unchanged

Expected Behavior

I expect the description to update accordingly

Steps to Reproduce

  1. Start up any given API tool im my example Bruno
  2. Send a HTTP Patch request to any node with a change description
  3. Receive a body, which does not reflect this change

Panel Version

1.11.7

Wings Version

1.11.13

Games and/or Eggs Affected

No response

Docker Image

No response

Error Logs

No response

Is there an existing issue for this?

  • I have searched the existing issues before opening this issue.
  • I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
  • I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.
@Luiggi33 Luiggi33 added the not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. label Aug 2, 2024
@Luiggi33
Copy link
Author

Luiggi33 commented Aug 2, 2024

I believe no logs are required for this issue, because the updating of the node description is the only issue I have come across so far

@MambaTheMaestro
Copy link

This was once added in another branch at 7d1cb29, though it looks like the description variable was omitted upon the initial commit of this 1.0-develop branch 11c4f3f6.

I'm not sure whether this change was intentional or not, but it appears to be a simple modification.

@Luiggi33
Copy link
Author

Luiggi33 commented Aug 2, 2024

Hmm, weird. As per the API docs, it should consume the description, odd that it's omitted. Thanks for the fix, tho. I hope that gets merged/fixed soon-ish.

@danny6167 danny6167 added bug Something that's not working as it's intended to be. and removed not confirmed Report seems plausible but requires additional testing or 3rd part confirmation. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that's not working as it's intended to be.
Projects
None yet
3 participants