Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end pipeline definition CRUD API tests #1457

Open
rrrliu opened this issue Feb 1, 2024 · 0 comments
Open

End to end pipeline definition CRUD API tests #1457

rrrliu opened this issue Feb 1, 2024 · 0 comments
Assignees
Labels

Comments

@rrrliu
Copy link
Collaborator

rrrliu commented Feb 1, 2024

No description provided.

@rrrliu rrrliu self-assigned this Feb 1, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 1, 2024
Closes #1428 

TODO
- [x] Request types
- [x] Move requests to passport-interface
- [x] Integrating with pipeline DB
- [x] Integrating with user DB
- [x] DB testing
- [ ] proposed refreshPipeline() in-memory command
#1456
- [ ] end-to-end API tests
#1457

What's in here:
- CRUD endpoints for pipeline definitions
- MVP UI that allows interacting with this CRUD UI via JSON (see video
below)
- Basic 'permission control' for the CRUD actions, e.g., you must own a
pipeline to delete it, but you can read or write to a pipeline if you
are either an owner or editor
- Pipeline Definition schema validation on the backend

What's not in here:
- The best state management / client-side fetching system
- Any admin user logic
- Comprehensive tests (in progress)


https://github.com/proofcarryingdata/zupass/assets/36896271/c3277ca4-caca-4249-868f-cc167c80f896
github-merge-queue bot pushed a commit that referenced this issue Feb 7, 2024
Not a great permanent solution, but unblocks an annoying bug right now.
The full solution will be done with a user auth slight refactor in #1457
@ichub ichub added the test label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants