Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report unresolvable merge conflicts #1372

Open
artwyman opened this issue Dec 18, 2023 · 0 comments
Open

Report unresolvable merge conflicts #1372

artwyman opened this issue Dec 18, 2023 · 0 comments
Assignees

Comments

@artwyman
Copy link
Collaborator

This is a follow-on to #1342.

The basic form of merge we've implemented for both PCDs and feeds is based on keeping all unique objects based on IDs (PCD ID, subscription ID, feed ID). There isn't currently any checking of the contents of a given PCD/subscription. If there are 2 different objects with the same ID, The structure of the merge implicitly prefers the "remote" copy, meaning the one which was on the server first. That has the potential to be wrong if a PCD is edited/replaced (rather than removed/added).

The first step in handling these situation is to detect it, and report it as part of the server event for merging conflicts. That will allow us to decide how often it happens, and how important it might be to fix.

@artwyman artwyman self-assigned this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant