Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there still a need for more p5.shader examples? #6134

Open
1 of 17 tasks
thantr opened this issue May 5, 2023 · 6 comments
Open
1 of 17 tasks

Is there still a need for more p5.shader examples? #6134

thantr opened this issue May 5, 2023 · 6 comments

Comments

@thantr
Copy link

thantr commented May 5, 2023

Increasing Access

As there already is a Mandelbrot set, I would love to work on and provide a webGL example that showcases a Julia set fractal

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)

Feature enhancement details

I am asking to see if there is any interest in a webGL live julia set example as there is a Mandelbrot set example. I would love to work on this please let me know as i would love to provide something like this

@welcome
Copy link

welcome bot commented May 5, 2023

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

@davepagurek
Copy link
Contributor

I think the Mandelbrot example we currently have is in the documentation for loadShader, but if one looks in the 3D section of the examples page, there aren't any fractal examples, so a Julia set would be great!

One thing I notice with the existing shader examples there is that if they use loadShader, the shader code isn't actually visible on the example page. Maybe it's worth using createShader and passing in the code as strings so that people can see the shader source on that page?

Also if you are interested in making a new capital-e Example (rather than an example directly in the reference for a function), those live here https://github.com/processing/p5.js-website/tree/main/src/data/examples/en/20_3D in the p5.js-website repo. If you make a PR there, feel free to tag me 🙂

@thantr
Copy link
Author

thantr commented May 6, 2023

Yes, I think having the shader code be visible would be a great idea! Thank you

@thantr thantr closed this as completed May 6, 2023
@thantr thantr reopened this May 6, 2023
@thantr
Copy link
Author

thantr commented May 24, 2023

Im not entirely sure if its done properly but I have created the pull request for the example

@davepagurek
Copy link
Contributor

That's this one right? https://github.com/processing/p5.js-website/pull/1364 I've tagged myself for review in there now, I'll take a look soon!

@thantr
Copy link
Author

thantr commented May 26, 2023

yes it is ! im eager to hear back from you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants