Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect OGP URL, Image Url and default Image type. #546

Open
shibomb opened this issue Sep 15, 2024 · 0 comments · May be fixed by #547
Open

Incorrect OGP URL, Image Url and default Image type. #546

shibomb opened this issue Sep 15, 2024 · 0 comments · May be fixed by #547
Labels
Bug Something isn't working

Comments

@shibomb
Copy link
Contributor

shibomb commented Sep 15, 2024

Most appropriate sections of the p5.js website?

Home

What is your operating system?

None

Web browser and version

No response

Actual Behavior

Incorrect OGP URL or image type.

  1. og:url and twitter:url start with localhost:4321.
  2. og:image and twitter:image is not full path.
  3. default og:image and twitter:image is an Astro's favicon.svg. (In addition, ogp image does not support svg.)
    スクリーンショット 2024-09-15 21 01 14
    スクリーンショット 2024-09-15 21 01 35

Expected Behavior

  1. og:url and twitter:url start with p5js.org
  2. og:image and twitter:image are set with full path.
  3. default ogp image is set to a type such as png, jpg, webp.

Steps to reproduce

For url and image url:
Open https://p5js.org , Check the meta tag in the head tag

For default image file:
Open https://p5js.org/reference/ , Check the meta tag in the head tag.

See attached image in Actual Behavior.

Would you like to work on the issue?

I will send PR with Temporary image.

@shibomb shibomb added the Bug Something isn't working label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant