Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to passport-github2 #1905

Closed
outofambit opened this issue Jul 19, 2021 · 1 comment · Fixed by #1931
Closed

migrate to passport-github2 #1905

outofambit opened this issue Jul 19, 2021 · 1 comment · Fixed by #1931

Comments

@outofambit
Copy link
Collaborator

GitHub recently deprecated API authentication through query parameters. #1618 removed all the calls we were making directly from the web editor, but it looks like this might still be a problem from these lines, where we use passport-github. passport-github hasn’t migrated from the deprecated GitHub API auth strategy and probably won’t since it seems to be unmaintained now (jaredhanson/passport-github#75).

But! someone has forked that repo and fixed this issue here: http://www.passportjs.org/packages/passport-github2/. Moving to passport-github2 should be enough to fix this. (it appears to be a drop in replacement for passport-github, so it might be as simple as changing the dependencies, but i haven't looked too closely.)

@welcome
Copy link

welcome bot commented Jul 19, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant