From a39cac77e479a2e9aa7122bf47b1e7104d61222d Mon Sep 17 00:00:00 2001
From: Connie Ye <constanceye1316@gmail.com>
Date: Thu, 15 Aug 2024 20:50:36 -0400
Subject: [PATCH] Fixes test suite warnings

Fixes the test suite warnings that are unrelated to the class -> functional conversion
---
 .../IDE/components/EditorAccessibility.unit.test.jsx       | 7 ++++---
 client/modules/IDE/components/ErrorModal.unit.test.jsx     | 6 +++---
 client/modules/IDE/components/FileNode.unit.test.jsx       | 6 +++++-
 .../project.controller/__test__/createProject.test.js      | 4 ++++
 server/controllers/project.controller/createProject.js     | 2 +-
 5 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/client/modules/IDE/components/EditorAccessibility.unit.test.jsx b/client/modules/IDE/components/EditorAccessibility.unit.test.jsx
index ca6dfd8686..444216935a 100644
--- a/client/modules/IDE/components/EditorAccessibility.unit.test.jsx
+++ b/client/modules/IDE/components/EditorAccessibility.unit.test.jsx
@@ -6,7 +6,7 @@ import EditorAccessibility from './EditorAccessibility';
 
 describe('<EditorAccessibility />', () => {
   it('renders empty message with no lines', () => {
-    render(<EditorAccessibility lintMessages={[]} />);
+    render(<EditorAccessibility lintMessages={[]} currentLine={0}/>);
 
     expect(
       screen.getByRole('listitem', {
@@ -21,11 +21,12 @@ describe('<EditorAccessibility />', () => {
         lintMessages={[
           {
             severity: 'info',
-            line: '1',
+            line: 1,
             message: 'foo',
-            id: '1a2b3c'
+            id: 123
           }
         ]}
+        currentLine={0}
       />
     );
 
diff --git a/client/modules/IDE/components/ErrorModal.unit.test.jsx b/client/modules/IDE/components/ErrorModal.unit.test.jsx
index 541276193c..625ff4635c 100644
--- a/client/modules/IDE/components/ErrorModal.unit.test.jsx
+++ b/client/modules/IDE/components/ErrorModal.unit.test.jsx
@@ -8,20 +8,20 @@ jest.mock('../../../i18n');
 
 describe('<ErrorModal />', () => {
   it('renders type forceAuthentication', () => {
-    render(<ErrorModal type="forceAuthentication" closeModal={jest.fn()} />);
+    render(<ErrorModal type="forceAuthentication" closeModal={jest.fn()} service="google" />);
 
     expect(screen.getByText('Login')).toBeVisible();
     expect(screen.getByText('Sign Up')).toBeVisible();
   });
 
   it('renders type staleSession', () => {
-    render(<ErrorModal type="staleSession" closeModal={jest.fn()} />);
+    render(<ErrorModal type="staleSession" closeModal={jest.fn()} service="google" />);
 
     expect(screen.getByText('log in')).toBeVisible();
   });
 
   it('renders type staleProject', () => {
-    render(<ErrorModal type="staleProject" closeModal={jest.fn()} />);
+    render(<ErrorModal type="staleProject" closeModal={jest.fn()} service="google" />);
 
     expect(
       screen.getByText(
diff --git a/client/modules/IDE/components/FileNode.unit.test.jsx b/client/modules/IDE/components/FileNode.unit.test.jsx
index 3f6706a2c0..664984b2ea 100644
--- a/client/modules/IDE/components/FileNode.unit.test.jsx
+++ b/client/modules/IDE/components/FileNode.unit.test.jsx
@@ -83,12 +83,16 @@ describe('<FileNode />', () => {
     });
 
     it('can change to a different extension', async () => {
+      let mockConfirm = jest.fn(() => true);
+      window.confirm = mockConfirm;  
+
       const newName = 'newname.gif';
       const props = renderFileNode('file');
 
       changeName(newName);
 
-      await waitFor(() => expect(props.updateFileName).not.toHaveBeenCalled());
+      expect(mockConfirm).toHaveBeenCalled();
+      await waitFor(() => expect(props.updateFileName).toHaveBeenCalledWith(props.id, newName));
       await expectFileNameToBe(props.name);
     });
 
diff --git a/server/controllers/project.controller/__test__/createProject.test.js b/server/controllers/project.controller/__test__/createProject.test.js
index 8ab179dd37..8a7ea8f67f 100644
--- a/server/controllers/project.controller/__test__/createProject.test.js
+++ b/server/controllers/project.controller/__test__/createProject.test.js
@@ -179,6 +179,10 @@ describe('project.controller', () => {
     });
 
     it('fails if user does not have permission', async () => {
+      // We don't want to clog up the jest output with extra
+      // logs, so we turn off console warn for this one test.
+      jest.spyOn(console, 'warn').mockImplementation(() => {});
+
       request.user = { _id: 'abc123', username: 'alice' };
       request.params = {
         username: 'dana'
diff --git a/server/controllers/project.controller/createProject.js b/server/controllers/project.controller/createProject.js
index 75e8ce84d0..021fbb21f2 100644
--- a/server/controllers/project.controller/createProject.js
+++ b/server/controllers/project.controller/createProject.js
@@ -59,7 +59,7 @@ export async function apiCreateProject(req, res) {
 
   const checkUserHasPermission = () => {
     if (req.user.username !== req.params.username) {
-      console.log('no permission');
+      console.warn('no permission');
       const error = new ProjectValidationError(
         `'${req.user.username}' does not have permission to create for '${req.params.username}'`
       );