diff --git a/client/modules/IDE/components/EditorAccessibility.unit.test.jsx b/client/modules/IDE/components/EditorAccessibility.unit.test.jsx
index ca6dfd868..444216935 100644
--- a/client/modules/IDE/components/EditorAccessibility.unit.test.jsx
+++ b/client/modules/IDE/components/EditorAccessibility.unit.test.jsx
@@ -6,7 +6,7 @@ import EditorAccessibility from './EditorAccessibility';
describe('', () => {
it('renders empty message with no lines', () => {
- render();
+ render();
expect(
screen.getByRole('listitem', {
@@ -21,11 +21,12 @@ describe('', () => {
lintMessages={[
{
severity: 'info',
- line: '1',
+ line: 1,
message: 'foo',
- id: '1a2b3c'
+ id: 123
}
]}
+ currentLine={0}
/>
);
diff --git a/client/modules/IDE/components/ErrorModal.unit.test.jsx b/client/modules/IDE/components/ErrorModal.unit.test.jsx
index 541276193..625ff4635 100644
--- a/client/modules/IDE/components/ErrorModal.unit.test.jsx
+++ b/client/modules/IDE/components/ErrorModal.unit.test.jsx
@@ -8,20 +8,20 @@ jest.mock('../../../i18n');
describe('', () => {
it('renders type forceAuthentication', () => {
- render();
+ render();
expect(screen.getByText('Login')).toBeVisible();
expect(screen.getByText('Sign Up')).toBeVisible();
});
it('renders type staleSession', () => {
- render();
+ render();
expect(screen.getByText('log in')).toBeVisible();
});
it('renders type staleProject', () => {
- render();
+ render();
expect(
screen.getByText(
diff --git a/client/modules/IDE/components/FileNode.unit.test.jsx b/client/modules/IDE/components/FileNode.unit.test.jsx
index 3f6706a2c..664984b2e 100644
--- a/client/modules/IDE/components/FileNode.unit.test.jsx
+++ b/client/modules/IDE/components/FileNode.unit.test.jsx
@@ -83,12 +83,16 @@ describe('', () => {
});
it('can change to a different extension', async () => {
+ let mockConfirm = jest.fn(() => true);
+ window.confirm = mockConfirm;
+
const newName = 'newname.gif';
const props = renderFileNode('file');
changeName(newName);
- await waitFor(() => expect(props.updateFileName).not.toHaveBeenCalled());
+ expect(mockConfirm).toHaveBeenCalled();
+ await waitFor(() => expect(props.updateFileName).toHaveBeenCalledWith(props.id, newName));
await expectFileNameToBe(props.name);
});
diff --git a/server/controllers/project.controller/__test__/createProject.test.js b/server/controllers/project.controller/__test__/createProject.test.js
index 8ab179dd3..8a7ea8f67 100644
--- a/server/controllers/project.controller/__test__/createProject.test.js
+++ b/server/controllers/project.controller/__test__/createProject.test.js
@@ -179,6 +179,10 @@ describe('project.controller', () => {
});
it('fails if user does not have permission', async () => {
+ // We don't want to clog up the jest output with extra
+ // logs, so we turn off console warn for this one test.
+ jest.spyOn(console, 'warn').mockImplementation(() => {});
+
request.user = { _id: 'abc123', username: 'alice' };
request.params = {
username: 'dana'
diff --git a/server/controllers/project.controller/createProject.js b/server/controllers/project.controller/createProject.js
index 75e8ce84d..021fbb21f 100644
--- a/server/controllers/project.controller/createProject.js
+++ b/server/controllers/project.controller/createProject.js
@@ -59,7 +59,7 @@ export async function apiCreateProject(req, res) {
const checkUserHasPermission = () => {
if (req.user.username !== req.params.username) {
- console.log('no permission');
+ console.warn('no permission');
const error = new ProjectValidationError(
`'${req.user.username}' does not have permission to create for '${req.params.username}'`
);