Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate maci deployment steps #1516

Open
ctrlc03 opened this issue May 30, 2024 · 2 comments
Open

consolidate maci deployment steps #1516

ctrlc03 opened this issue May 30, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented May 30, 2024

Currently there are two ways of deploying MACI's contracts, via the cli or the contracts tasks. Given the contracts tasks are a much better solution, we should consolidate our processes and documentation to remove any confusion, and focus improvements only on one of the two methods.

For this, we could create a separate package which can be used for deployment (and other tasks like merging and proving)

@ctrlc03 ctrlc03 added the enhancement New feature or request label May 30, 2024
@ctrlc03 ctrlc03 added the good first issue Good for newcomers label Sep 8, 2024
@0xshikhar
Copy link

0xshikhar commented Oct 1, 2024

hey @ctrlc03, i can work on this task. Can you assign me this?

@0xmad
Copy link
Collaborator

0xmad commented Oct 3, 2024

@0xshikhar so the main idea here is to use maci-contracts task helpers (Deployer, Prover, ProofGenerator and etc) inside maci-cli, so we don't duplicate the code. maci-cli will have only terminal module and argument parser with validation. Main functionality will be used from thehelpers from maci-contracts.
@ctrlc03 potentially, user interaction won't be affected and api will be the same, only internal parts will be changed just to get rid of duplicated code. In case if we want to drop maci-cli in the future, we still have maci-contracts with core logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants