Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests do not account for NOTHING_UP_MY_SLEEVE #1153

Open
ctrlc03 opened this issue Feb 5, 2024 · 4 comments
Open

unit tests do not account for NOTHING_UP_MY_SLEEVE #1153

ctrlc03 opened this issue Feb 5, 2024 · 4 comments
Assignees
@wildanvin
Labels
good first issue Good for newcomers testing Issue/PR related to tests

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Feb 5, 2024

The unit tests for maci core, do not account that the NOTHING_UP_MY_SLEEVE message is to be inserted at position 0. While not a problem for unit tests, these should be amended.
@ctrlc03 ctrlc03 added good first issue Good for newcomers testing Issue/PR related to tests labels Jul 15, 2024
@wildanvin
Copy link
Contributor

Hello,
I would like to work on this issue please

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Sep 11, 2024

Hello, I would like to work on this issue please

Awesome, assigned you! thank you and lmk if you need any help/clarification

@wildanvin
Copy link
Contributor

Hello! Sorry for the delay, I got lost in the path of life...

I'll be submitting the PR later this week for sure... I will ask some questions maybe tomorrow in order to make sure I understand everything correctly

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Sep 25, 2024

Hello! Sorry for the delay, I got lost in the path of life...

I'll be submitting the PR later this week for sure... I will ask some questions maybe tomorrow in order to make sure I understand everything correctly

@wildanvin no problem at all, thanks again for tackling this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wildanvin wildanvin

Labels
good first issue Good for newcomers testing Issue/PR related to tests
Projects
MACI team sprint board
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wildanvin @ctrlc03