Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Coverage #1051

Open
1 task done
kittybest opened this issue Jan 18, 2024 · 2 comments
Open
1 task done

Improve Code Coverage #1051

kittybest opened this issue Jan 18, 2024 · 2 comments
Labels
testing Issue/PR related to tests

Comments

@kittybest
Copy link
Collaborator

kittybest commented Jan 18, 2024

Prerequisites

Please answer the following question for yourself before submitting a feature request.

  • I checked to make sure that this request has not already been filed

Motivation

There are still conditions not being tested, and we only know them until someone runs under certain condition and report the bug.
Wanna find a way to reduce this problem.

Details

Currently we test the code coverage by nyc
(which was done in #932)
(previous closed issue is this: #931)

Try to improve testing the code coverage more automatically and completely by codecov

Make sure that you have reviewed MACI's Contributor Guidelines

@kittybest
Copy link
Collaborator Author

problems to be discussed: codecov charges monthly subscription fee, do we really need it? or we only need nyc?

@samajammin
Copy link
Member

problems to be discussed: codecov charges monthly subscription fee, do we really need it? or we only need nyc?

Looks like free for open source projects, so we should be good? https://about.codecov.io/pricing/

@ctrlc03 ctrlc03 added the testing Issue/PR related to tests label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issue/PR related to tests
Projects
Status: Todo
Development

No branches or pull requests

3 participants