Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit with only numbers appears to violate semver #135

Open
skovy opened this issue Jan 30, 2022 · 0 comments
Open

Commit with only numbers appears to violate semver #135

skovy opened this issue Jan 30, 2022 · 0 comments
Labels
type/bug Something is not working the way it should

Comments

@skovy
Copy link

skovy commented Jan 30, 2022

Screenshot

image

Description

Commit hash with only numbers appears to violate semver. I wasn't able to confirm it was due to the numbers, but the next attempt succeeded as expected with no changes. That version was: 0.0.0-pr.7.1.f4c705a. I'm assuming it's due to the commit 0137094 being only numbers?

Repro Steps/Link

Try publishing a package with only numbers in the commit hash: 0.0.0-pr.7.1.0137094

Run yarn -s dripip preview-or-pr
    Error: The following command failed to complete successfully:

            yarn publish --tag pr.7 --no-git-tag-version --new-version 
    0.0.0-pr.7.1.0137094

        It ended with this exit code:

            1

        This underlying error occured (null = none occured):

            null

        It received signal (null = no signal received):

            null

        It output on stderr (null = not spawned in pipe mode):

            error Couldn't publish package: 
    "https://registry.yarnpkg.com/css-codemod: New versions must be valid 
    semver."


        It output on stdout (null = not spawned in pipe mode):
@skovy skovy added the type/bug Something is not working the way it should label Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is not working the way it should
Projects
None yet
Development

No branches or pull requests

1 participant