Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dripip is dependent on an unreleased version of chaindown #111

Open
jsoref opened this issue Feb 23, 2021 · 4 comments
Open

dripip is dependent on an unreleased version of chaindown #111

jsoref opened this issue Feb 23, 2021 · 4 comments
Labels
type/bug Something is not working the way it should

Comments

@jsoref
Copy link
Contributor

jsoref commented Feb 23, 2021

https://github.com/jsoref/dripip/runs/1958285925?check_suite_focus=true

FAIL src/sdk/preview.spec.ts
● Test suite failed to run

src/lib/changelog/renderers/markdown.ts:14:25 - error TS2339: Property 'create' does not exist on type 'typeof import("/home/runner/work/dripip/dripip/node_modules/chaindown/dist/index")'.

14   const doc = Chaindown.create()
                           ~~~~~~

For reference, it would be fine if the current version of chaindown -- I made a release and then tried using it:

jsoref@3390406

https://github.com/jsoref/dripip/runs/1958670635?check_suite_focus=true

@jasonkuhrt -- could you release it so that this repo could be unbroken?

@jasonkuhrt
Copy link
Member

@jsoref thanks for reporting! Will fix this today or tomorrow.

@jasonkuhrt jasonkuhrt added the type/bug Something is not working the way it should label Feb 23, 2021
@jasonkuhrt
Copy link
Member

I just cut a canary release, can you try it and report back? Thanks!

https://github.com/prisma-labs/dripip/releases/tag/next

@jsoref
Copy link
Contributor Author

jsoref commented Feb 23, 2021

https://github.com/prisma-labs/dripip/releases/tag/next still lists a 2020 date.

I'm only trying to get my PRs to pass CI:

@jasonkuhrt
Copy link
Member

@jsoref Got it! Could you try rebasing #108?

@jasonkuhrt jasonkuhrt reopened this Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is not working the way it should
Projects
None yet
Development

No branches or pull requests

2 participants