Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to update NCBI URLs #18

Open
deepakunni3 opened this issue Dec 10, 2018 · 1 comment
Open

need to update NCBI URLs #18

deepakunni3 opened this issue Dec 10, 2018 · 1 comment

Comments

@deepakunni3
Copy link
Collaborator

deepakunni3 commented Dec 10, 2018

All of the NCBI services have upgraded to using HTTPS but several of the URLs in the context JSON-LD are still using HTTP URL.

This results in no CURIE returned when contracting a URI using curie_util.contract_uri().

For example,

# URI with https yields no result
curie_util.contract_uri('https://www.ncbi.nlm.nih.gov/gene/9628')
[] 
# URI with http yields the correct CURIE
curie_util.contract_uri('http://www.ncbi.nlm.nih.gov/gene/9628')
['NCBIGene:9628']

But it's not clear ahead of time if all the incoming URIs are HTTP or HTTPS.

@cmungall

@deepakunni3 deepakunni3 changed the title need to update (or enumerate) NCBI URLs need to update NCBI URLs Dec 10, 2018
@deepakunni3
Copy link
Collaborator Author

This issue came up with monarch_context.jsonld.
Perhaps we have to update this JSON-LD every time Monarch makes a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant