User sync Issue introduced by PR 2948

[matthieularere-msq]

I've just found an issue introduced by this PR : #2948 👍

prebid-server/usersync/syncer.go

Line 129 in 9693132

redirectURL := macroRegexSyncerKey.ReplaceAllLiteralString(redirectTemplate, bidderName)

By using bidderName it makes that if the usersync key has a different value, then request sent to the bidder won't have any value for the User.BuyerUID openrtb field.
It happens that this is precisely the case for appnexus adapter which use adnxs as a key. It makes that user sync for this bidder no longer works.

[SyntaxNode]

PR #2948 accounts for the change from syncer key to bidder name by swapping the syncersByKey function for syncersByBidder. The syncer key is still used in the Prebid Server cookie, thus no change is necessary for the BuyerID lookup.

I tested this flow to ensure it's working as intended and could not find an issue. Are you experiencing a problem?

[SyntaxNode]

@matthieularere-msq This functionality appears to be working correctly. Please confirm if you're seeing an issue in production.

[matthieularere-msq]

I happened to have an issue with my setuid endpoint, I guess it was caused by a merge issue with my fork.