resolvePriceGranularity does not use account price granularity

[muuki88]

I found an unexpected behaviour in the Ortb2ImplicitParameterResolver class.
My configuration looks like this

• no price granularity send from prebid (I'm debugging still why this is the case)
• price-granularity is set on the account and properly loaded
• /openrtb/auction (web) endpoint is used

I debugged the ortb2 bid request sent to Xandr (AppNexusBidder) and it contains the PriceGranularity.Default instead of the one I have configured in the account settings. I found this code

prebid-server-java/src/main/java/org/prebid/server/auction/requestfactory/Ortb2ImplicitParametersResolver.java

Lines 626 to 631 in 7b96266

	final boolean hasAllMediaTypes = checkExistingMediaTypes(targeting.getMediatypepricegranularity())
	.containsAll(getImpMediaTypes(imps));
	if (isPriceGranularityNull && !hasAllMediaTypes) {
	return mapper.mapper().valueToTree(ExtPriceGranularity.from(PriceGranularity.DEFAULT));
	}

What I don't understand is: when the priceGranularity is null and the mediaType price granularity doesn't cover all the cases it should fallback to the account settings and not default-default, right?

[bretg]

Thanks for the issue @muuki88 . It's a known shortcoming that PBS-Java doesn't support custom price granularities in account config -- that's issue #2314. Is that the scenario here or something different?

But in any case, there appears to be a bug here - agree that account-level granularity should take precedence over default-default.

[muuki88]

Thanks for your response 🤗

Custom price granularity is not the issue here. It's for sure a nice to have, but we wouldn't need it as we only have one, which we could easily add ourselves.

As you mentioned correctly, not falling back to the account price granularity, but the default, is IMHO a bug. As I don't see where else it should be used 😅