From f6429cec697aaa8ab64e85b441ee6e4ad93642ca Mon Sep 17 00:00:00 2001 From: Powei Lin Date: Mon, 11 Mar 2024 17:29:10 -0400 Subject: [PATCH] clean up --- src/gauss_newton_optimizer.rs | 7 ++----- src/linear.rs | 3 ++- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/gauss_newton_optimizer.rs b/src/gauss_newton_optimizer.rs index c17375c..91755ad 100644 --- a/src/gauss_newton_optimizer.rs +++ b/src/gauss_newton_optimizer.rs @@ -1,9 +1,6 @@ -use std::ops::Mul; -use std::time::{Duration, Instant}; +use std::time::Instant; -use faer::solvers::{SpSolver, SpSolverLstsq}; use faer_ext::IntoNalgebra; -use nalgebra as na; use crate::{linear::sparse_cholesky, optimizer}; pub struct GaussNewtonOptimizer {} @@ -31,6 +28,6 @@ impl optimizer::Optimizer for GaussNewtonOptimizer { let dx_na = dx.as_ref().into_nalgebra().column(0).clone_owned(); self.apply_dx(&dx_na, &mut params, &problem.variable_name_to_col_idx_dict); } - return params; + params } } diff --git a/src/linear.rs b/src/linear.rs index 6e84e28..23dae08 100644 --- a/src/linear.rs +++ b/src/linear.rs @@ -1,6 +1,7 @@ -use faer::prelude::SpSolver; use std::ops::Mul; +use faer::prelude::SpSolver; + pub fn sparse_cholesky( residuals: &faer::Mat, jacobians: &faer::sparse::SparseColMat,