Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin configuration args is not passed to plugin command #238

Open
Jaakkonen opened this issue Aug 24, 2024 · 0 comments
Open

Plugin configuration args is not passed to plugin command #238

Jaakkonen opened this issue Aug 24, 2024 · 0 comments

Comments

@Jaakkonen
Copy link

Jaakkonen commented Aug 24, 2024

In the plugin.ron there's an option to configure the executable arguments:

(
  name: "testing",
  description: "test plugin",
  bin: (
    path: "my-program",
    args: ["pop-plugin",],
  ),
  query: (
    persistent: true,
  )
)

However this option is not passed to the actual arguments when creating the ExternalPlugin that eventually starts the program upon first query.

ExternalPlugin::new(id, name.clone(), exec.clone(), Vec::new(), tx)

Either the args option should be removed from the configuration, the deprecation of it should be documented, or the arguments should be passed to the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant