Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability of CycleRange and RepeatRange #740

Open
bash opened this issue Jul 24, 2023 · 1 comment · May be fixed by #773
Open

Usability of CycleRange and RepeatRange #740

bash opened this issue Jul 24, 2023 · 1 comment · May be fixed by #773
Labels
enhancement New feature or request

Comments

@bash
Copy link
Member

bash commented Jul 24, 2023

CycleRange returns an IBuffer which brings with it the need to dispose the result which is not very practical.

I think we should add an overload for readonly lists that returns a regular old IEnumerable (that's easy because the list is already materialized).

We can either add an overload of the existing CycleRange (that's a source breaking change though).
Alternatively we can use a new name (e.g. CycleList).

@bash bash added the enhancement New feature or request label Jul 24, 2023
@bash bash changed the title Usability of CycleRange Usability of CycleRange and RepeatRange Jul 24, 2023
@FreeApophis
Copy link
Member

I think the names should be different, and I think List is the best name for this kind of abstraction:

alternative suggestions, I list stupid ideas too, to make us think one more time:

  • Repeat/CycleMaterialized
  • Repeat/CycleEager(Range, Collection)
  • Repeat/CycleInMemory
  • Repeat/Cycle

We could mark this feature as Experimental as long as we are not sure about the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants