From 1d1cc028dd10cd908e1dd706100e4a051ead9a71 Mon Sep 17 00:00:00 2001 From: Leonardo Diez Date: Wed, 4 Oct 2017 15:46:32 +0200 Subject: [PATCH] Iban validator test fix. --- lib/active_model/validations/iban_validator.rb | 1 + spec/validators/iban_validator_spec.rb | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/active_model/validations/iban_validator.rb b/lib/active_model/validations/iban_validator.rb index 4da66f0..10f29df 100644 --- a/lib/active_model/validations/iban_validator.rb +++ b/lib/active_model/validations/iban_validator.rb @@ -14,6 +14,7 @@ def validate_each(record, attribute, value) elsif !IbanBic.valid_check?(value) record.errors.add(attribute, :invalid_check) elsif !IbanBic.valid_country_check?(value) + record.errors.add(attribute, :invalid_country_check) end end diff --git a/spec/validators/iban_validator_spec.rb b/spec/validators/iban_validator_spec.rb index 88ea7b5..8167d9b 100644 --- a/spec/validators/iban_validator_spec.rb +++ b/spec/validators/iban_validator_spec.rb @@ -32,9 +32,14 @@ def self.model_name end context "when invalid country digits" do - let(:iban_digits) { "17" } + let(:iban_digits) { "07" } let(:country_digits) { "00" } - it { is_expected.to be_invalid } + it "iban is valid" do + expect(IbanBic.valid_check?(iban)).to be_truthy + end + it "but country digits not" do + is_expected.to be_invalid + end end context "when invalid format" do