Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JVM] Port async node plugin #459

Open
sugarmanz opened this issue Jul 29, 2024 · 0 comments
Open

[JVM] Port async node plugin #459

sugarmanz opened this issue Jul 29, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@sugarmanz
Copy link
Member

sugarmanz commented Jul 29, 2024

Port internal async node plugin implementation

plugins/async-node
├── core
│   ├── BUILD
│   ├── src
│   └── package.json
└── jvm
    ├── BUILD
    ├── deps.bzl
    ├── src/main/kotlin/com/intuit/playerui/plugins/asyncnode
    │   └── AsyncNodePlugin.kt
    └── src/test/kotlin/com/intuit/playerui/plugins/asyncnode
        └── AsyncNodePluginTest.kt

The jvm/BUILD file should make use of the kt_player_plugin macro (ex. plugins/beacon/jvm/BUILD).

deps.bzl is for organizing dependencies, which for a lot of plugins is just the dependency on JVM core and the native plugin bundle (ex. plugins/beacon/jvm/deps.bzl).

@sugarmanz sugarmanz added the enhancement New feature or request label Jul 29, 2024
@KetanReddy KetanReddy added this to the 1.0 milestone Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants