Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterMethod #50

Open
MIJOTHY opened this issue May 15, 2015 · 1 comment
Open

filterMethod #50

MIJOTHY opened this issue May 15, 2015 · 1 comment

Comments

@MIJOTHY
Copy link

MIJOTHY commented May 15, 2015

Firstly, you can condense Array.prototype.filter to [].filter. Secondly, the main aim for your code should be readability. The section in which you're using filterMethod isn't particularly readable. Consider splitting up up rather than chaining callback blocks upon callback blocks. Otherwise nice js.

@rjmk
Copy link
Contributor

rjmk commented May 16, 2015

Thanks for the [].filter trick. I have been working on the readability of the code and will keep tweaking it over the course.

Thanks for looking at our code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants